[Bug 665911] Ability to specify ignore-length in wavparse

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Dec 13 01:24:41 PST 2011


https://bugzilla.gnome.org/show_bug.cgi?id=665911
  GStreamer | gst-plugins-good | 0.10.x

Stefan Sauer (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203277|none                        |needs-work
             status|                            |

--- Comment #8 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2011-12-13 09:24:40 UTC ---
Review of attachment 203277:
 --> (https://bugzilla.gnome.org/review?bug=665911&attachment=203277)

thanks for the quick patch. Just two minor nitpicks.

::: gst/wavparse/gstwavparse.c
@@ +147,3 @@
+
+  /**
+   * GstDeinterlace:mode

Please fix the docblob :)

@@ +1404,3 @@
           wav->offset += size;
         }
+        GST_DEBUG_OBJECT (wav, "datasize = %u", size);

In earlier log statements it is still %d. 'size' is guint32, right? Could you
change the otehr logs statements too (preferably as a separate commit).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list