[Bug 627459] theoraenc should provide option for TH_ENCCTL_SET_DUP_COUNT

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=627459
  GStreamer | gst-plugins-base | 0.10.x

Vincent Penquerc'h <vincent.penquerch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203893|none                        |needs-work
             status|                            |

--- Comment #51 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2011-12-19 17:19:31 UTC ---
Review of attachment 203893:
 --> (https://bugzilla.gnome.org/review?bug=627459&attachment=203893)

::: ext/theora/gsttheoraenc.c
@@ +1343,3 @@
+      if (t_queue_length > 1) {
+        res = th_encode_ctl (enc->encoder, TH_ENCCTL_SET_DUP_COUNT,
+            &t_queue_length, sizeof (t_queue_length));

You haven't either changed this, or confirmed it it not requesting one dupe too
much.

@@ +1394,3 @@
+    GstClockTime timestamp = 0;
+    GST_DEBUG_OBJECT (enc, "encoded. granule:%x, packet:%p, "
+        "bytes:%u", op.granulepos, op.packet, op.bytes);

granulepos is 64 bit, this will not work right on 32 bit archs. Use
G_GINT64_FORMAT (not nice to read, but the least bad of options I think).
op.bytes is a long too, use %ld.

@@ +1411,2 @@
   }
+  /* ESO or discontinuos, is not a viald situation, so there is nothing

Typos left.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.