[Bug 666579] [a52dec] behavior changed since porting to audiodecoder

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=666579
  GStreamer | gst-plugins-ugly | git

Mark Nauwelaerts <mnauw> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.20

--- Comment #4 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2011-12-20 12:01:22 UTC ---
As for the remaining behaviour; the old one was not entirely nice/ok, as it
would totally ignore errors and possibly carry on indefinitely.  Evidently, the
new is not quite convenient either giving up at the first sign of trouble.

Following minor -base commit to audiodecoder arranges for intended behaviour,
which is to only really give up in seriously problematic cases (ongoing
errors).  The remaining discont marking/handling is all done automagically by
the specialized GST_AUDIO_DECODER_ERROR macro and the rest of buffer handling
code.

----

commit c41f3cbef03417c3025b145122788502764313ad
Author: Mark Nauwelaerts <mark.nauwelaerts at collabora.co.uk>
Date:   Tue Dec 20 12:42:18 2011 +0100

    audiodecoder: set a non-zero default maximum tolerated errors

    Whereas the previous default 0 was backwards compatible in that it lead
    to erroring out immediately upon any error, elements that are really
    ported and using the base class error macro can be assumed to intend to
    improve behaviour rather than maintaining the old one.  So, make it easy
    on those and any future one and tolerate some errors by default, as
intended.

    Fixes #666579.

... and in 0.10 release branch ...

commit 10aabf623abfa17b29a1e65d403923e36716c3a7
Author: Mark Nauwelaerts <mark.nauwelaerts at collabora.co.uk>
Date:   Tue Dec 20 12:42:18 2011 +0100

    audiodecoder: set a non-zero default maximum tolerated errors

    Whereas the previous default 0 was backwards compatible in that it lead
    to erroring out immediately upon any error, elements that are really
    ported and using the base class error macro can be assumed to intend to
    improve behaviour rather than maintaining the old one.  So, make it easy
    on those and any future one and tolerate some errors by default, as
intended.

    Fixes #666579.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.