[Bug 666626] [dtmfsrc] Fixing source pad event handler

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=666626
  GStreamer | gst-plugins-bad | git

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #204007|none                        |needs-work
             status|                            |

--- Comment #1 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2011-12-21 01:33:32 UTC ---
Review of attachment 204007:
 --> (https://bugzilla.gnome.org/review?bug=666626&attachment=204007)

You're definitely right that something is wrong here..

::: gst/dtmf/gstdtmfsrc.c
@@ +412,3 @@
   GST_DEBUG_OBJECT (dtmfsrc, "Received an event on the src pad");
   if (GST_EVENT_TYPE (event) == GST_EVENT_CUSTOM_UPSTREAM) {
+    return gst_dtmf_src_handle_custom_upstream (dtmfsrc, event);

I would do this and always pass it to the base class in case BaseSrc starts
accepting some custom upstream events in the future

if (GST_EVENT_TYPE (event) == GST_EVENT_CUSTOM_UPSTREAM)
 gst_dtmf_src_handle_custom_upstream (dtmfsrc, event)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.