[gstreamer-bugs] [Bug 629196] oggmux: re-tagging an Ogg Vorbis file may corrupt audio data

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=629196
  GStreamer | gst-plugins-base | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.33
            Summary|Tagging an Ogg Vorbis file  |oggmux: re-tagging an Ogg
                   |may corrupt audio data      |Vorbis file may corrupt
                   |                            |audio data

--- Comment #12 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-02-02 17:39:12 UTC ---
commit 54c19ba6def4f9cead7e18a893c981e425f9405c
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Wed Feb 2 17:30:15 2011 +0000

    oggmux: free stream map caps when done

commit 2eac43bd73ff405c6883c1c2476a90a123b52159
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Wed Feb 2 17:23:43 2011 +0000

    oggmux: keep IN_CAPS flag check for header buffers as fallback

    In case the ogg mapper doesn't handle all the accepted input formats
    (although it really should). Saves us error handling for that case
    though. Also log caps properly.

    https://bugzilla.gnome.org/show_bug.cgi?id=629196

commit 440002a137640db2c5d6613d9bf56dfff997eb07
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Fri Jan 21 16:05:46 2011 +0000

    oggmux: use oggstream for less brittleness in recognizing headers

    Using the IN_CAPS flag for this is brittle, and will fail if either
    vorbisparse or vorbistag (which is itself based on vorbisparse) is
    inserted between oggdemux and oggmux. Possibly other elements too
    (eg, theoraparse, etc).
    Using oggstream ensures we Get It Right More Often Than Not.

    https://bugzilla.gnome.org/show_bug.cgi?id=629196

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.