[gstreamer-bugs] [Bug 640211] oggmux: ensure serialnos are unique
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Thu Feb 3 01:35:15 PST 2011
https://bugzilla.gnome.org/show_bug.cgi?id=640211
GStreamer | gst-plugins-base | unspecified
Tim-Philipp Müller <t.i.m> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
Target Milestone|HEAD |0.10.33
--- Comment #7 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-02-03 09:35:13 UTC ---
Thanks, committed:
commit 96a1a9dec6676826dd808d6c35a5ae3f7f276212
Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date: Fri Jan 21 18:10:29 2011 +0000
oggmux: ensure serialnos are unique
We do that by checking a newly generated one is not already used in
an existing stream, and doing it again if it is.
https://bugzilla.gnome.org/show_bug.cgi?id=640211
I did one small change:
- serialno = g_random_int();
+serialno = g_random_int_range (0, G_MAXINT32);
to avoid pads named like 'sink_-418411', which is a bit awkward (generally the
ogg code seems to be a bit confused about the type and sign of the serial
number, and GStreamer about it's pad templates, using sink_%d when it really
wants sink_%u)
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the Gstreamer-bugs
mailing list