[gstreamer-bugs] [Bug 641530] Camerabin should capture image if preview_caps is set even if filename is not set

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=641530
  GStreamer | gst-plugins-bad | git

--- Comment #3 from Luciana Fujii <luciana at fujii.eti.br> 2011-02-08 20:13:55 UTC ---
(In reply to comment #2)
> Review of attachment 180100 [details]:
> 
> ::: gst/camerabin/gstcamerabin.c
> @@ +4049,3 @@
> +
> +  if (g_str_equal (camera->filename->str, ""))
> +    if (camera->active_bin == camera->vidbin || !camera->preview_caps) {
> 
> why only in video-mode?

Thanks for your comments.

If camerabin is in video-mode, than it should always fail if filename is not
set, since preview-caps only affects image-mode. If camerabin is in image-mode
it should only fail if preview-caps is not set.

That is what being tested there. I tried to add a comment to make it more
clear, because I know the code is not that nice to read.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.