[Bug 634250] deserialize URI strings into GstBuffer

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Feb 17 08:11:15 PST 2011


https://bugzilla.gnome.org/show_bug.cgi?id=634250
  GStreamer | gstreamer (core) | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #3 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-02-17 16:11:08 UTC ---
> I changed logoinsert in -bad to use a GstBuffer property instead of a location=
> property.  This allows applications to set the property using a binary blob
> containing a PNG image, while also allowing the old behavior of using
> gst-launch to load the image from a file.

As I said in our discussion on IRC the other, I think this is awful API. I
think the location=localfile.png case is the most common, and I don't see the
problem with having a separate "data" property for the buffer data. IIRC you
expressed a dislike for having file reading code in elements like this, which I
agree with on some level, but we shouldn't invent awkward API to avoid that
IMHO.

I would prefer to see this WONTFIXed, and see a plain "location" string
property on that overlay element (and additional "data" GstBuffer property if
desired).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list