[Bug 641330] icydemux: crash while playing MP3 stream in amarok

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=641330
  GStreamer | gst-plugins-good | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.28

--- Comment #3 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-02-21 11:34:09 UTC ---
I wasn't able to reproduce the problem with the streams I tried, but hopefully
this should fix it:

 commit 06972db7b6a55f951833327a659afc76bef6b5c8
 Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
 Date:   Mon Feb 21 00:55:49 2011 +0000

    icydemux: fix tag list handling issues that might have caused crashes

    Fix slightly confused tag handling in some places: make it clear when
    we're taking ownership of a tag list and when not. For example,
    gst_icydemux_tag_found() was taking ownership when the source pad
    existed, but otherwise not (leak). Also, gst_event_parse_tag() does
    not return a newly-allocated taglist, but a tag list that belongs to
    the tag event, so don't give ownership of it away.

    While we're at it, some minor clean-ups: don't re-invent g_strndup()
    and simplify gst_icydemux_parse_and_send_tags() a bit, and don't
    leak the tag list in case no valid tags where found.

    https://bugzilla.gnome.org/show_bug.cgi?id=641330


If you have some particular radio stations/streams this happens with, it would
be great if you could give me the URL (or make a GST_DEBUG=*:5 debug log).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.