[Bug 595520] Implement a generic cairo overlay

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=595520
  GStreamer | gst-plugins-good | git

--- Comment #15 from Sebastian Dröge <slomo at circular-chaos.org> 2011-02-28 21:01:51 UTC ---
Looks good to me, just two small comments :) After that this can be committed
IMHO unless we really want the enable/disable behaviour from the very beginning


ext/cairo/Makefile.am
10    built_headers = gstcairo-marshal.h
11     
12    BUILT_SOURCES = $(built_sources) $(built_headers)
You're including the marshaller even if cairo-gobject is not found
ext/cairo/gstcairooverlay.c


163          cairo_image_surface_create_for_data (GST_BUFFER_DATA (buf),
format,
164          overlay->caps_width, overlay->caps_height,
165          cairo_format_stride_for_width (format, overlay->caps_width));
Use width*4 in any case, the cairo preffered format stride could be different
and you must use the GStreamer stride here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.