[gstreamer-bugs] [Bug 638535] New: multiple genres as per ID3v2.4 not supported correctly

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=638535
  GStreamer | gst-plugins-good | git

           Summary: multiple genres as per ID3v2.4 not supported correctly
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: erich at debian.org
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


MP3 files with multiple genres and ID3v2.4 tags are not supported correctly.
Only the first genre will show up in the results.

I believe I've found the bug by staring at the source code long enough. I did
NOT get around to building it myself and validating the fix.

But have a look at:

gst-plugins-good/tree/gst/id3demux/id3v2frames.c line 875 and following:

  for (i = 0; i < tag_fields->len; i++) {
    gint len;

    tag_str = g_array_index (tag_fields, gchar *, 0);

(in method "id3v2_genre_fields_to_taglist" which explains why this applies to
multiple genre tags but not to multiple artists)

In my opinion, this will read the first "genre" tag n times, instead of
properly iterating over the array. I propose replacing the "0" with an "i".

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.