[gstreamer-bugs] [Bug 623240] Memory allocation fails when reading .xm (audio/x-mod) file metadata

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=623240
  GStreamer | don't know | 0.10.29

--- Comment #4 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2011-01-07 11:11:41 UTC ---
Seems fine with that file as well. I noticed a little bug in libmodplug with
Impulse Tracker modules, though, patch below (Sourceforge doesn't seem to want
me to post that patch on the modplug tracker). I doubt it'd cause memory
corruption, but it depends how delete/delete[] are implemented. In any case,
that issue doesn't seem to be with gstreamer itself.


diff --git a/libmodplug/src/sndfile.cpp b/libmodplug/src/sndfile.cpp
index 4cb0646..1145986 100644
--- a/libmodplug/src/sndfile.cpp
+++ b/libmodplug/src/sndfile.cpp
@@ -285,12 +285,12 @@ BOOL CSoundFile::Destroy()
        m_nPatternNames = 0;
        if (m_lpszPatternNames)
        {
-               delete m_lpszPatternNames;
+               delete[] m_lpszPatternNames;
                m_lpszPatternNames = NULL;
        }
        if (m_lpszSongComments)
        {
-               delete m_lpszSongComments;
+               delete[] m_lpszSongComments;
                m_lpszSongComments = NULL;
        }
        for (i=1; i<MAX_SAMPLES; i++)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.