[gstreamer-bugs] [Bug 639063] mpegtsparse is holding the data (not pushing it further)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=639063
  GStreamer | gst-plugins-bad | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177871|none                        |reviewed
             status|                            |

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-01-09 23:53:04 UTC ---
(From update of attachment 177871)
>diff --git a/gst/mpegdemux/mpegtspacketizer.c b/gst/mpegdemux/mpegtspacketizer.c
>index 70cf3d7..0792b6d 100644
>--- a/gst/mpegdemux/mpegtspacketizer.c
>+++ b/gst/mpegdemux/mpegtspacketizer.c
>@@ -2108,8 +2118,13 @@ mpegts_try_discover_packet_size (MpegTSPacketizer * packetizer)
>   GST_DEBUG ("have packetsize detected: %d of %u bytes",
>       packetizer->know_packet_size, packetizer->packet_size);
>   /* flush to sync byte */
>-  if (pos > 0)
>+  if (pos > 0) {
>+    /* flush to sync byte */
>     gst_adapter_flush (packetizer->adapter, pos);
>+  } else {
>+    /* drop some invalid data and move to the next possible packets */
>+    gst_adapter_flush (packetizer->adapter, MPEGTS_MAX_PACKETSIZE);
>+  }
>   g_free (dest);
> }
> 

Are you sure this is correct?
  ....
  } else if (pos < 0) {
     gst_adapter_flush (packetizer->adapter, MPEGTS_MAX_PACKETSIZE);
  }
  ...

would make more sense to me.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.