[gstreamer-bugs] [Bug 600929] [kate] tiger element doesn't handle segments and text/video synchronization properly

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=600929
  GStreamer | gst-plugins-bad | git

--- Comment #43 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-01-12 17:08:30 UTC ---
(From update of attachment 178156)
>+#define GST_KATE_TIGER_GET_COND(element) ((element)->cond)
>+#define GST_KATE_TIGER_WAIT(element) (g_cond_wait (GST_KATE_TIGER_GET_COND (element), (element)->mutex))        //GST_OBJECT_GET_LOCK (element)))
>+#define GST_KATE_TIGER_SIGNAL(element) (g_cond_signal (GST_KATE_TIGER_GET_COND (element)))
>+#define GST_KATE_TIGER_BROADCAST(element) (g_cond_broadcast (GST_KATE_TIGER_GET_COND (element)))

No C++ comments please (guess the GST_OBJECT_GET_LOCK can just be removed?).

Nitpick: It's easy to shoot yourself in the foot with this kind of macro
definition (with element not cast to GstKateTiger* or whatever before
dereferencing in GET_COND and in _WAIT).

> It would be nice it this could go on the release despite the freeze.
> Since the element had rank NONE, this would not cause any
> regression.

Go for it.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.