[gstreamer-bugs] [Bug 639321] deinterlace: field{1, 3} scanline pointers seem to be off by one field line

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=639321
  GStreamer | gst-plugins-good | git

--- Comment #5 from Robert Swain <robert.swain at gmail.com> 2011-01-12 23:59:16 UTC ---
Review of attachment 178184:
 --> (https://bugzilla.gnome.org/review?bug=639321&attachment=178184)

This seems to fix all the issues I observed as well as making the code far
easier to read and hence maintain. Nice.

::: gst/deinterlace/gstdeinterlacemethod.c
@@ +351,3 @@
     scanlines.bottom_field = (cur_field_flags == PICTURE_INTERLACED_BOTTOM);

+    if (!((i & 1) ^ (cur_field_flags == PICTURE_INTERLACED_BOTTOM))) {

You can use scanlines.bottom_field here instead of the expression. Unless
scanlines.bottom_field is not used anywhere else in which case it could be
removed.

@@ +454,3 @@
     scanlines.bottom_field = (cur_field_flags == PICTURE_INTERLACED_BOTTOM);

+    if (!((i & 1) ^ (cur_field_flags == PICTURE_INTERLACED_BOTTOM))) {

scanlines.bottom_field can be used here too instead of the expression.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.