[gstreamer-bugs] [Bug 639555] [audioparsers] Be careful to not lose the event ref

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=639555
  GStreamer | gst-plugins-bad | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #178345|none                        |accepted-commit_now
             status|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-01-14 21:16:27 UTC ---
(From update of attachment 178345)
> audioparsers: baseparse: Be careful to not lose the event ref
> 
> Only unref the event if it has been handled.

I think something like this would be clearer: "Don't unref event if it hasn't
been handled, because the caller will assume it's still valid and can be
re-used in that case. Fixes issue with xyz", or somesuch.

(The comment above the function should probably also mention the unusual
calling semantics.)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.