[gstreamer-bugs] [Bug 625129] typefinding: file incorrectly detected as audio/x-dts

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=625129
  GStreamer | gst-plugins-base | git

--- Comment #6 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2011-01-25 10:22:08 UTC ---
> Since there's supposed to be a 34-byte header, we may just as well check for
> that (not that it matters).

Why not. Done.

> Isn't resolution a bitfield? (meaning shouldn't it be <= 3?)

I think it is not. Rereading the desription, it is indeed not very clear, but
the following paragraph seems clear enough to quash the uncertainty (look at
the example values given):

1 word          resolution (same as Degas, but high order bit is set;
                i.e., hex 8000 = low res, hex 8001 = medium res,
                hex 8002 = high res).  Other bits may be used in the
                future; use a simple bit test rather than checking
                for specific word values.

> Not sure I understand the nesting here.

"oops". Yes, bad nesting. The other too, it was copy/paste/adapt.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.