[gstreamer-bugs] [Bug 640859] basesink default drift-tolerance causes glitches on some clips

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=640859
  GStreamer | gst-plugins-base | git

--- Comment #3 from Felipe Contreras <felipe.contreras at gmail.com> 2011-01-30 13:30:16 UTC ---
(In reply to comment #2)
> (From update of attachment 179546 [details])
> >Subject: [PATCH] baseaudiosink: increase drift-tolerance to 100ms
> >
> > ...
> >Note that this value was 500ms previously.
> 
> Hrm?

http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=d8942e2

-  /* we tollerate half a second diff before we start resyncing. This
-   * should be enough to compensate for various rounding errors in the
timestamp
-   * and sample offset position. We always resync if we got a discont anyway
and
-   * non-discont should be aligned by definition. */
-  if (G_LIKELY (diff < ringbuf->spec.rate / DIFF_TOLERANCE)) {

Note that DIFF_TOLERANCE is 2, and it was never removed.

Anyway, you have increased it in the past:
http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=848a7f2

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.