[gstreamer-bugs] [Bug 640859] basesink default drift-tolerance causes glitches on some clips

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=640859
  GStreamer | gst-plugins-base | git

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #179642|none                        |rejected
             status|                            |

--- Comment #18 from Edward Hervey <bilboed at gmail.com> 2011-01-31 09:29:22 UTC ---
(From update of attachment 179642)
Ok, this was crack indeed. I apologize for even proposing it in the first
place, should have thought more about it.

That file is *broken*. If ever we want to put an acceptable fix anywhere, it
should be in the matroskademuxer.

* Detecting for example that the time provided for the lace has increased by
too little (1-4ms) compared to the previous one for the nature of the stream
(smallest compressed codec packets should be at least 10ms).
* Looking over the next/previous 5/10 packets to determine that the lace time
is incorrect.

And whenever we detect an incorrect lace_time in the demuxer for the outgoing
buffer we set its timestamp to CLOCK_TIME_NONE, which will either:
* Make decoders timestamp it to the expected next timestamp based on the number
of previously decoded samples
* Have baseaudiosink do that for us.

Fixing it there instead of breaking a behaviour that works fine for 99.9999999%
of the files/use-cases is the proper way to go in the end.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.