[gstreamer-bugs] [Bug 640985] Create a videosink that makes it possible to interact with QGraphicsView

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=640985
  GStreamer | qt-gstreamer | git

George Kiagiadakis <kiagiadakis.george> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #179671|none                        |needs-work
             status|                            |

--- Comment #1 from George Kiagiadakis <kiagiadakis.george at gmail.com> 2011-01-31 09:52:12 UTC ---
Review of attachment 179671:
 --> (https://bugzilla.gnome.org/review?bug=640985&attachment=179671)

This patch is wrong because you removed the events. Now, the updateBuffer()
function is called from the streaming thread and the repaint() function from
the main thread and there is no queue between them, and no mutex either! This
is guaranteed to crash. You should re-add the trick with the events.

Plus, I explained last time that sending the image as the signal argument is
also not ok, as it creates the need for doing an unnecessary copy of the image
inside the widget/graphicsitem before it can be painted.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.