[Bug 644404] [rtspsrc/jitterbuffer] position increasing while buffering

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=644404
  GStreamer | gst-plugins-good | git

René Stadler <mail> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #190930|none                        |needs-work
             status|                            |

--- Comment #11 from René Stadler <mail at renestadler.de> 2011-07-04 20:40:47 UTC ---
Review of attachment 190930:
 --> (https://bugzilla.gnome.org/review?bug=644404&attachment=190930)

In gst_base_sink_get_position, you are not initializing the new boolean
variable "buffering". I have no idea why the compiler isn't warning about this.
On -O2 I could understand (since it gets optimized away), but in -O0 I can
clearly step through with gdb, which shows in my case buffering is 42
initially.

I guess you want to set this to FALSE initially, just as "in_paused".

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.