[Bug 605834] directsoundsink: 16-bit audio is always signed while 8-bit is always unsigned

Sat Jul 9 16:47:21 PDT 2011

https://bugzilla.gnome.org/show_bug.cgi?id=605834
  GStreamer | gst-plugins-good | git

David Schleef <ds> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.31

--- Comment #7 from David Schleef <ds at schleef.org> 2011-07-09 23:47:17 UTC ---
commit fbe726c3da9bb8e46291c1186a11e53866f14a9e
Author: Philip Jägenstedt <philipj at opera.com>
Date:   Fri Nov 20 10:07:43 2009 +0100

    directsoundsink: 16-bit audio is signed, 8-bit is unsigned.

    Pretending to handle 8-bit signed causes distorted audio when
    actually given such audio, which you will get if passing 8-bit
    unsigned through audioconvert ! audioresample, as audioresample
    only handles 8-bit signed.  Fixes #605834.

    Signed-off-by: David Schleef <ds at schleef.org>

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.