[Bug 652951] vp8enc: Set correct timestamp/duration for altref/invisible frames

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=652951
  GStreamer | gst-plugins-bad | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #191680|none                        |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge <slomo at circular-chaos.org> 2011-07-11 07:02:26 UTC ---
Review of attachment 191680:
 --> (https://bugzilla.gnome.org/review?bug=652951&attachment=191680)

::: ext/vp8/gstvp8enc.c
@@ +993,3 @@
     GST_BUFFER_FLAG_SET (buf, GST_BUFFER_FLAG_INVISIBLE);
+    GST_BUFFER_TIMESTAMP (buf) = encoder->last_ts +
+        (GST_BUFFER_TIMESTAMP (frame->src_buffer) - encoder->last_ts) / 2;

You need to initialize last_ts to something sane (e.g. 0 or segment start) in
::reset for the case when the first frame is an altref frame.
Also this means that multiple altref frames after another have all the same
timestamp

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.