[Bug 654416] New: [mpegtsmux] gst_buffer_unref () call segfaults

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=654416
  GStreamer | gst-plugins-bad | git

           Summary: [mpegtsmux] gst_buffer_unref () call segfaults
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: sameer.subscriptions at damagehead.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Upon testing my gstreamer application, i found that mpegtsmux plugin segfaults
occasionally when trying to unref the buffer in the
mpegtsmux_choose_best_stream () call. Specifically the line:

gst/mpegtsmux/mpegtsmux.c:646
gst_buffer_unref (gst_collect_pads_pop (mux->collect, c_best));

I found that the gst_collect_pads_pop () call returns no buffer (NULL), this
results in gst_buffer_unref (NULL) to be called resulting in a segmentation
fault.

Attached patch fixes the issue.

P.S. The patch is generated against the git.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.