[Bug 654572] Set but unused warning
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Thu Jul 14 15:26:53 PDT 2011
https://bugzilla.gnome.org/show_bug.cgi?id=654572
GStreamer | gst-plugins-bad | git
--- Comment #5 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2011-07-14 22:26:51 UTC ---
That clarify a bit the what to do.
For assrender, ignoring the stride of an image seems wrong, so I'd suggest
commenting out with FIXME and a bug id to go with it. The caps in lv2, I think
they can simply be removed.
For the timestamp in modplug I just have no idea, thus if 0 might be better.
But I don't see obvious reason to file a bug.
In sndfile, there is good chance that the dicount boolean should result in
setting discount flag on the created buffer, but again I don't have any
context.
Finally the rest seems correct fix to me, like the wildmidi fix where stuff in
ifdef had variable declaration outside those ifdef.
So I suggest I squash all this, replace the /* */ with ifdef, file a bug for
assrender and set discount flag in sndfile. Those that make sense ?
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list