[Bug 654583] Immediate RTCP in rtpsession

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=654583
  GStreamer | gst-plugins-good | git

Mark Nauwelaerts <mnauw> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mnauw at users.sourceforge.net

--- Comment #6 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2011-07-25 13:58:41 UTC ---
(In reply to comment #2)
> Created an attachment (id=191934)
 View: https://bugzilla.gnome.org/attachment.cgi?id=191934
 Review: https://bugzilla.gnome.org/review?bug=654583&attachment=191934

> rtpsession: Always send application requested feedback in immediate mode
> 
> Send as many application requested feedback messages in immediate mode, even if
> they
> have already been sent.

> -  /*  RFC 4585 section 3.5.2 step 4 */
> -  if (sess->allow_early == FALSE)
> +  /*  RFC 4585 section 3.5.2 step 4
> +   * But allow feedback anyway if we are below the immediate feedback threshold
> +   */
> +  if (sess->total_sources < sess->rtcp_immediate_feedback_threshold ||
> +      sess->allow_early == FALSE)
>      goto dont_send;

Seems odd here; the intention is apparently to allow feedback/sending if below
threshold, but the code path will go to dont_send (which does not sound
promising ...)

There is also a stray empty line added somewhere, and the default value for the
new property is not set in _init (afaics).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.