[Bug 655361] New: pcapparse: fix SLL parsing

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=655361
  GStreamer | gst-plugins-bad | unspecified

           Summary: pcapparse: fix SLL parsing
    Classification: Platform
           Product: GStreamer
           Version: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: felipe.contreras at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=192681)
 View: https://bugzilla.gnome.org/attachment.cgi?id=192681
 Review: https://bugzilla.gnome.org/review?bug=655361&attachment=192681

Proposed patch

The current code is not checking for ethernet type, as it's supposed to, but
link layer device type and it's hard-coded to only accept dumps from ethernet
(ARPHRD_ETHER; 1). We don't care where the dump was fetched from (wlan, 3G,
etc.)

What we care about is the that the ethernet type is IP (ETHERNET_IP; 0x800),
which is clearly field 14:

http://www.tcpdump.org/pcap3_man.html

And do a bit of cleanup.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.