[Bug 655361] [PATCH] pcapparse: fix SLL parsing

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=655361
  GStreamer | gst-plugins-bad | unspecified

Mark Nauwelaerts <mnauw> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |mnauw at users.sourceforge.net
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.23

--- Comment #2 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2011-07-27 08:37:48 UTC ---
Thanks.

commit 046af98b301396570488a56443fdd1d8c5aacd79
Author: Felipe Contreras <felipe.contreras at nokia.com>
Date:   Tue Jul 26 19:11:16 2011 +0300

    pcapparse: fix SLL parsing

    The current code is not checking for ethernet type, as it's supposed to,
    but link layer device type and it's hard-coded to only accept dumps from
    ethernet (ARPHRD_ETHER; 1). We don't care where the dump was fetched
    from (wlan, 3G, etc.)

    What we care about is the that the ethernet type is IP (ETHERNET_IP;
    0x800), which is clearly field 14:

    http://www.tcpdump.org/pcap3_man.html

    And do a bit of cleanup.

    Signed-off-by: Felipe Contreras <felipe.contreras at nokia.com>

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.