[Bug 581011] Move DVB plugins to -good

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Jun 10 15:01:46 PDT 2011


https://bugzilla.gnome.org/show_bug.cgi?id=581011
  GStreamer | gst-plugins-good | 0.10.x

--- Comment #5 from David Schleef <ds at schleef.org> 2011-06-10 22:01:41 UTC ---

(In reply to comment #4)
> > dvbsrc should have a device= property, like v4l2src.
> how would be different from the adapter and frontend properties ?
> one adapter(ie. device) could potentially have multiple frontend.

Other plugins usually use a char * property to indicate the device.

> > Restore timeout property from 5616efb0.
> Yes there are many timeouts inside the logic, one for the poll, one for
> acquiring the signal, one for retrying. and are all "timeout" but
> I think the main timeout sense is how long should wait before giving
> up in tuning. right ?

Yeah, the timeout property would only be for "how long to wait until the
application is told that data is not flowing", which would apply to tuning as
well as signal loss.  We could have separate timeouts for both of those, but I
don't think there's much value in having two.

I think this is the only thing that really needs to be fixed before merging
your branch into bad.  (Which I suppose we could talk about on that bug
report.)

> > Move gst_dvbsrc_plugin_init() somewhere else.
> why ? 

Style preference.  I didn't mean for you to have to fix all these things
yourself before moving to -good, but a checklist of things that need to be
done.  This is something that I would do.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list