[Bug 644233] Set the H.264 level from the caps for encoding

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Jun 13 19:28:46 PDT 2011


https://bugzilla.gnome.org/show_bug.cgi?id=644233
  GStreamer | gst-plugins-ugly | git

--- Comment #21 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2011-06-14 02:28:37 UTC ---
Review of attachment 189593:
 --> (https://bugzilla.gnome.org/review?bug=644233&attachment=189593)

::: ext/x264/gstx264enc.c
@@ +1556,3 @@
+
+    gst_caps_unref (peer_caps);
+  }

shouldn't we have:

else {
  allowed_caps = peer_caps;
}

also, a few more comments on why the above is necessary would be good.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list