[Bug 650313] ac3parse: Add support for iec61937 alignment

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=650313
  GStreamer | gst-plugins-good | unspecified

--- Comment #5 from Arun Raghavan <arun at accosted.net> 2011-06-21 23:26:48 UTC ---
Thank you for the reviews, Sebastian! (and sorry for taking so long to get
back)

(In reply to comment #4)
> Review of attachment 187912 [details]:
> 
> ::: gst/audioparsers/gstac3parse.c
> @@ +202,3 @@
> +
> +  klass->baseparse_src_event = parse_class->src_event;
> +  parse_class->src_event = GST_DEBUG_FUNCPTR (gst_ac3_parse_src_event);
> 
> Just override ->src_event and then chain up in the event function via
> GST_BASE_PARSE_CLASS(parent_class)->src_event(bparse, event);

Ack.

> @@ +597,3 @@
>      gst_caps_set_simple (caps, "alignment", G_TYPE_STRING,
> +        g_atomic_int_get (&ac3parse->align) == GST_AC3_PARSE_ALIGN_IEC61937 ?
> +        "iec61937" : "frame", NULL);
> 
> You should check if the alignment has changed here and only create new caps if
> the caps actually changed, otherwise just set GST_PAD_CAPS() on the buffers

We're actually only setting all this if some other parameters changed, so new
caps would be needed anyway. Or are you saying that the way it was originally
done should be fixed (which makes more sense, I suppose).

> ::: gst/audioparsers/gstac3parse.h
> @@ +72,3 @@
>  struct _GstAc3ParseClass {
>    GstBaseParseClass baseparse_class;
> +  gboolean (*baseparse_src_event) (GstBaseParse * parse, GstEvent * event);
> 
> Not needed

Ack.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.