[Bug 644768] [dcaparse] implement 14-to-16-bit conversion

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=644768
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #190519|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2011-06-26 12:37:47 UTC ---
Review of attachment 190519:
 --> (https://bugzilla.gnome.org/review?bug=644768&attachment=190519)

Run gst-indent on your changes before committing and use "git format-patch"
style patches.

For the negotiation you can take a look at h264parse, it negotiates the format
and alignment with downstream.

::: gst/audioparsers/gstdcaparse.c
@@ +422,3 @@
+    tmp = data[pos];
+    data[pos] = data[pos+1];
+    data[pos+1] = tmp;

Just do GST_WRITE_UINT16_LE(data, GST_READ_UINT16_BE (data)) here. Also, do it
at the same time when converting between 14<->16 bits

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.