[Bug 652951] matroskamux and vp8enc: filed to set invisble flag for vp8 altref frames

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=652951
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #190376|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2011-06-26 12:48:01 UTC ---
Review of attachment 190376:
 --> (https://bugzilla.gnome.org/review?bug=652951&attachment=190376)

::: ext/vp8/gstvp8enc.c
@@ +993,3 @@
+    encoder->last_invisible_ts = encoder->last_timestamp + 1;
+    GST_BUFFER_TIMESTAMP (buf) = encoder->last_timestamp + 1;
+    GST_BUFFER_DURATION (buf) = encoder->last_duration;

The duration of invisible frames should be 1 then. Please also note that the
timestamps and durations here are in nanoseconds and in matroskamux they are in
microseconds or whatever, depending on the timescale property.

Does it also work if you give the same timestamps as the previous visible frame
and a duration of 0?

@@ +1018,3 @@
+
+  if (encoder->last_invisible_ts == encoder->last_timestamp)
+    GST_WARNING_OBJECT (encoder, "oops, last_invisible_ts ==
currnet_timestamp");

Make this a g_warning

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.