[Bug 652951] matroskamux and vp8enc: filed to set invisble flag for vp8 altref frames

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=652951
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #190695|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge <slomo at circular-chaos.org> 2011-06-26 13:30:52 UTC ---
Review of attachment 190695:
 --> (https://bugzilla.gnome.org/review?bug=652951&attachment=190695)

::: ext/vp8/gstvp8enc.c
@@ +991,3 @@
     }

+    encoder->last_invisible_ts = encoder->last_timestamp + GST_MSECOND;

Same problem as before, depending on the timecode scale you could get the same
timestamp as for the previous visible frame

@@ +1018,3 @@
+
+  if (encoder->last_invisible_ts == encoder->last_timestamp)
+    g_warning ("oops, last_invisible_ts == currnet_timestamp");

Typo here and please use something more descriptive, including the element name
and something that could be understood by the user

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.