[Bug 653080] [PATCH] matroskamux: make check for block_duration less sensible

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=653080
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #190343|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2011-06-26 13:33:25 UTC ---
Review of attachment 190343:
 --> (https://bugzilla.gnome.org/review?bug=653080&attachment=190343)

::: gst/matroska/matroska-mux.c
@@ +2768,3 @@
   /* Check if the duration differs from the default duration. */
   write_duration = FALSE;
+  block_duration = GST_TIME_AS_MSECONDS (GST_BUFFER_DURATION (buf));

Instead of GST_TIME_AS_MSECONDS you should do something that uses
mux->time_scale

@@ +2771,3 @@
   if (GST_BUFFER_DURATION_IS_VALID (buf)) {
+    if (block_duration !=
+        GST_TIME_AS_MSECONDS (collect_pad->track->default_duration))

Maybe do this conversion a single time only. And allow a difference of +/- 1 ms
for rounding errors.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.