[Bug 653718] New: d3dvideosink compilation with MinGW

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=653718
  GStreamer | gst-plugins-bad | git

           Summary: d3dvideosink compilation with MinGW
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Windows
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: lrn1986 at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


There are a few problems. One of them (the lack of DECLARE_INTERFACE_IID_
macro) can only be fixed by MinGW devs (i've already filed a bug report).
Others are on gst side.

First, some definitions in d3dvideosink code are unused, and since gstreamer is
built with -Werror, they trigger a build failure. The attached patches fix that
by adding _attribute_ ((unused)). Since this code, apparently, also compiles
with MSVC (or at least someone will want to compile it with MSVC), it might be
a good idea to use some kind of macro for this attribute, such as:
#ifdef _MSC_VER
#define UNUSED
#else
#define UNUSED _attribute_ ((unused))
#endif

Second, makefile for d3dvideosink doesn't use any special C/LD flag variables.
I don't know how other people compile it, but i often make use of variables,
such as PLUGINNAME_CFLAGS and PLUGINNAME_LDFLAGS to pass plugin-specific flags
(usually - include directories and library directories). Other
direct-x-dependent plugins in -bad already make use of DIRECTX_CFLAGS and
DIRECTX_LDFLAGS, and the patch here adds these variables to d3dvideosink as
well.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.