[Bug 564122] Crash in monoscope_update

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=564122
  GStreamer | gst-plugins-good | 0.10.x

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |ensonic at sonicpulse.de
     Ever Confirmed|0                           |1

--- Comment #4 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2011-03-02 08:57:01 UTC ---
commit d2ee8b979d84f0e714e502116b6fafd9f1d68d16
Author: Stefan Kost <ensonic at users.sf.net>
Date:   Wed Mar 2 10:56:33 2011 +0200

    monoscope: stack needs to be size+1 as we put a end-marker into it

    Valgrind is still complaining about one bad read, but this takes care of
the
    crash mentioned in the comment and in bug #564122.

I still get one invalid read:

==15142== Invalid read of size 4
==15142==    at 0x4069AD3: monoscope_update (monoscope.c:129)
==15142==    by 0x4069710: gst_monoscope_chain (gstmonoscope.c:395)

==15142==  Address 0x5611584 is 0 bytes after a block of size 134,924 alloc'd
==15142==    at 0x40260BB: calloc (in
/usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==15142==    by 0x4069822: monoscope_init (monoscope.c:68)
==15142==    by 0x4069075: gst_monoscope_src_setcaps (gstmonoscope.c:234)
==15142==    by 0x40C656B: gst_pad_set_caps (gstpad.c:2692)
==15142==    by 0x4068ABB: get_buffer (gstmonoscope.c:269)
==15142==    by 0x4069724: gst_monoscope_chain (gstmonoscope.c:344)

but the crash is fixed.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.