[Bug 402141] gst_element_factory_can_{sink,src}_caps seems to be broken

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=402141
  GStreamer | gstreamer (core) | git

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #164475|none                        |needs-work
             status|                            |

--- Comment #19 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2011-03-07 15:06:36 UTC ---
Review of attachment 164475:
 --> (https://bugzilla.gnome.org/review?bug=402141&attachment=164475)

Looks good. Small comments below. Also some tests would be nice.

::: gst/gstutils.c
@@ +1307,3 @@
  * Returns: true if it can src the capabilities
+ *
+ * Deprecated

The tag is "Deprecated: use gst_element_factory_can_src_all_caps() instead".

@@ +1310,3 @@
  */
 gboolean
 gst_element_factory_can_src_caps (GstElementFactory * factory,

what about calling the "all" version to avoid code duplication.

@@ +1343,3 @@
  * Returns: true if it can sink the capabilities
+ *
+ * Deprecated

The tag is "Deprecated:  use gst_element_factory_can_sink_all_caps() instead".

@@ +1346,2 @@
  */
+

remove :)

@@ +1348,3 @@
 gboolean
 gst_element_factory_can_sink_caps (GstElementFactory * factory,
     const GstCaps * caps)

see above.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.