[Bug 424143] Hello world too complicated

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=424143
  GStreamer | documentation | 0.10.x

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.33

--- Comment #6 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2011-03-08 07:44:41 UTC ---
(In reply to comment #5)
> Looks good to me. Niggles:
> 
>  - argv[1] needs to be a URI, but the help string
>    says 'media file'. Maybe add some kind of
> 
>    if (gst_uri_is_valid (argv[1]))
>      uri = g_strdup (argv[1]);
>    else
>      uri = gst_filename_to_uri (argv[1], NULL);
> 
>    (this is also something that trips up
>    people quite a lot, so might be worth
>    having in a hello world).

good idea. Fixed.

> 
>  - wonder if for a first version it would be even
>    better to get rid of the main loop, and
>    just do a
> 
>    while ((msg = gst_bus_*()) {
>      ...
>    }
> 
>    instead. (Many people don't understand
>    main loops, or are confused by them).

I added a couple of comment lines instead. I think the main-loop is as short as
the usual event_loop helper we use, but I think its better to have a 'proper
example'.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.