[Bug 643301] Adding a buffer to a buffer list iterates the list

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Mar 11 05:33:02 PST 2011


https://bugzilla.gnome.org/show_bug.cgi?id=643301
  GStreamer | gstreamer (core) | git

Wim Taymans <wim.taymans> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.33

--- Comment #3 from Wim Taymans <wim.taymans at gmail.com> 2011-03-11 13:32:57 UTC ---
commit c4c06a2b883388d39c9a9ed5d6cb09110812226e
Author: Jonas Holmberg <jonas.holmberg at axis.com>
Date:   Fri Feb 25 16:20:49 2011 +0100

    bufferlist: Use a GQueue instead of a GList

    Adding a buffer to the end of a GstBufferList is supposed to be a fast
    operation, but it was not since the iterator does not advance its
    nextpointer when adding buffers and GList does not have a tail pointer.
    Using a GQueue to store the buffers makes it easier to add buffers to
    the end of the list and this operation will now be much more efficient.

    Adding an entire GList of buffers using
    gst_buffer_list_iterator_add_list() will however have to iterate over
    the list being added to be able to update the tail pointer in the
    GQueue.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list