[Bug 644730] [matroskamux] Should return TRUE in the event function when the event is handled

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Mar 14 08:05:29 PDT 2011

  GStreamer | gst-plugins-good | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
 Attachment #183346|none                        |needs-work
             status|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-03-14 15:05:26 UTC ---
(From update of attachment 183346)
What we want to achieve (aiui): current behaviour is maintained, only that we
return TRUE for tag events that are not forwarded, because it's been handled.

It looks to me like your patch changes behaviour so that the tag event is now
forwarded (if it doesn't crash before that).

"if (ret) chain->up()" should be changed to "if (event) chain->up()". event
should also be set to NULL in the newsegment part then.

Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the gstreamer-bugs mailing list