[Bug 641191] [dvbsrc] Add a property to configure the dvb-api buffer size

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Mar 14 14:06:12 PDT 2011

  GStreamer | gst-plugins-bad | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
                 CC|                            |t.i.m at zen.co.uk

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-03-14 21:06:06 UTC ---
Could you elaborate a bit on how/why this is useful exactly? 

You're drastically reducing the DMX_BUFFER_SIZE from 1MB to 8kB here if I read
this correct - won't that be problematic if read()s aren't done fast enough,
e.g. because downstream blocks for a short while, as often happens? (I see that
8kB is also the default buffer size, just wondering...)

May I suggest that the property be a normal signed int, defaulting to -1, in
which case dvbsrc just uses whatever defaults it deems best? Why not just call
it "buffer-size"?

Some more nitpicks:

 - instead of logging errno, please log g_strerror(errno).

 - in property description, mention that the size is in bytes

 - please don't indent header files, only .c files should be

Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the gstreamer-bugs mailing list