[Bug 639763] [dvbsuboverlay] Green borders around subtitles

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Mar 16 19:21:30 PDT 2011

  GStreamer | gst-plugins-bad | git

Mart Raudsepp <leio> changed:

           What    |Removed                     |Added
 Attachment #183582|none                        |reviewed
             status|                            |

--- Comment #4 from Mart Raudsepp <leio at gentoo.org> 2011-03-17 02:21:24 UTC ---
Review of attachment 183582:
 --> (https://bugzilla.gnome.org/review?bug=639763&attachment=183582)

Nice work! I was debugging this today as well, and got to alpha values being
the problem, but after a break fortunately noticed bugmail from you instead of
continuing :)
Got around to looking through it, thinking about it and testing some, and
indeed this is the issue and the obvious fix. Now I also remember (and
re-confirmed) that Finnish DVB Subtitle streams tend to contain green YUV
values for the parts where full transparency is declared in the alpha channel,
back from the decoding work when I spit those out in raw PNGs.

I see you already work inside GIT - maybe you could also commit it with a nice
commit message and send that (after possibly tweaking something per this or
other comments), so it's easily applied with proper authorship information?

::: gst/dvbsuboverlay/gstdvbsuboverlay.c
@@ +657,1 @@

I see you simplify the logic of dealing with this by pre-multiplying U and V
channels above. Maybe the same premultiplying logic would be nice for the last
block too (for odd height and width), where there's no alpha issue concerns,
just for consistencies sake?

Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the gstreamer-bugs mailing list