[Bug 645006] [mpegtsmux] in m2ts-mode, PAT is written only once

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat Mar 26 00:12:39 PDT 2011

  GStreamer | gst-plugins-bad | git

Jan Schmidt <thaytan> changed:

           What    |Removed                     |Added
                 CC|                            |thaytan at mad.scientist.com

--- Comment #4 from Jan Schmidt <thaytan at mad.scientist.com> 2011-03-26 07:12:35 UTC ---
This seems to be completely fixed with this commit, despite the commit msg only
saying partially fixed:

commit 9a26173a57b05ecb497fe1fca0168b5cbd4c0167
Author: Jan Schmidt <thaytan at noraisin.net>
Date:   Sat Mar 26 15:58:21 2011 +1100

    Rewrite M2TS packet output

    Make sure we only write the bottom 30 bits of the PCR to the m2ts header.
    Don't use floating point computation for it, and remove weird bit fiddling
    that messes up the PCR in a way I can't find any
    justification/documentation for.

    Don't accidentally lose PCR packets from the output.

    Fix the description for the m2ts-mode property so it's clear it's a flag,
    and which setting does what.

    Fixes: #611061 #644429
    Partially fixes: #645006

There's no need to disable the pat_changed flag in the tsmux, it's set when a
new program is added to the set, to indicate the PAT needs re-generating,
otherwise the old PAT is just output.

Please re-open if you see any other trouble.

Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the gstreamer-bugs mailing list