[Bug 645167] [xmp] Add a new XmpConfig interface

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=645167
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #184500|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge <slomo at circular-chaos.org> 2011-03-29 10:07:22 UTC ---
Review of attachment 184500:
 --> (https://bugzilla.gnome.org/review?bug=645167&attachment=184500)

Looks good to me in general.

::: gst-libs/gst/tag/xmpwriter.c
@@ +111,3 @@
+
+  if (data->schemas)
+    g_slist_free_full (data->schemas, g_free);

g_[s]list_free_full() is new since GLib 2.28. And you can call it on NULL too
(NULL is a valid GList/GSList)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.