[Bug 646118] [gstmultiqueue] if arbitrary sink number is specified by caller, use this as single queue id

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Mar 29 11:53:13 PDT 2011

  GStreamer | gstreamer (core) | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
 Attachment #184600|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2011-03-29 18:53:10 UTC ---
Review of attachment 184600:
 --> (https://bugzilla.gnome.org/review?bug=646118&attachment=184600)

::: plugins/elements/gstmultiqueue.c
@@ +598,3 @@
+    sscanf (name + 4, "%d", &id);
+  } else
+    id = mqueue->nbqueues++;

You should hold the multiqueue mutex while accessing the nbqueues variable.
Also double check (while holding that mutex) that the ID is not used yet when a
name was provided by the caller

Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the gstreamer-bugs mailing list