[Bug 621663] x264enc: support changing bitrate property on the fly

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=621663
  GStreamer | gst-plugins-ugly | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177609|none                        |accepted-commit_now
             status|                            |

--- Comment #31 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-03-29 21:50:09 UTC ---
(From update of attachment 177609)
Looks fine to me.

>   state = GST_STATE (encoder);
>-  if (state != GST_STATE_READY && state != GST_STATE_NULL)
>+  if ((state != GST_STATE_READY && state != GST_STATE_NULL) &&
>+      !(pspec->flags & GST_PARAM_MUTABLE_PLAYING))
>     goto wrong_state;

(Nitpick: I guess & (MUTABLE_PLAYING | MUTABLE_PAUSED) would be more correct,
but it doesn't matter currently, and is unlikely to ever matter, since PAUSED
vs. PLAYING behaviour is the same for an encoder, so MUTABLE_PAUSED doesn't
make sense)..

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.