[Bug 629244] [opencv] Add motion detection element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=629244
  GStreamer | gst-plugins-bad | git

--- Comment #35 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2011-05-03 08:30:25 UTC ---
(In reply to comment #33)
> I fixed some warnings,but these remainings:
> 
> gstmotioncells.c: In function ‘gst_motioncells_set_property’:
> gstmotioncells.c:351: warning: passing argument 1 of ‘gst_element_get_state’
> from incompatible pointer type

Just add a GST_ELEMENT() cast to filter:
filter->ret= gst_element_get_state (GST_ELEMENT(filter),
              &filter->state, &filter->pending, 250 * GST_NSECOND);


> /usr/local/include/gstreamer-0.10/gst/gstelement.h:807: note: expected ‘struct
> GstElement *’ but argument is of type ‘struct Gstmotioncells *’
> gstmotioncells.c:362: warning: passing argument 1 of ‘gst_element_get_state’
> from incompatible pointer type
> /usr/local/include/gstreamer-0.10/gst/gstelement.h:807: note: expected ‘struct
> GstElement *’ but argument is of type ‘struct Gstmotioncells *’
> gstmotioncells.c:394: warning: passing argument 1 of ‘gst_element_get_state’
> from incompatible pointer type
> /usr/local/include/gstreamer-0.10/gst/gstelement.h:807: note: expected ‘struct
> GstElement *’ but argument is of type ‘struct Gstmotioncells *’

> cc1plus: warning: command line option "-Wdeclaration-after-statement" is valid
> for C/ObjC but not for C++

you need to declare your variable at the start of a { scope.

> cc1plus: warning: command line option "-Wmissing-prototypes" is valid for
> Ada/C/ObjC but not for C++

we require function prototypes before using the function. Either declare stuff
in bottom up way or add prototypes preferably in one block at the top of the
source.

> cc1plus: warning: command line option "-Wold-style-definition" is valid for
> Ada/C/ObjC but not for C++
> cc1plus: warning: command line option "-Wnested-externs" is valid for C/ObjC
> but not for C++

> gstmotioncells.c: In function ‘gst_motioncells_chain’:
> gstmotioncells.c:760: warning: suggest parentheses around ‘&&’ within ‘||’

just add extra () braces to make the evaluation order more explicit.

> 
> 
> if you can please fix these warnings.
> Send patch.
> 
> Thanks,
> 
> Robert

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.