[Bug 640859] basesink incorrectly categorizes timestamp jitter as drift

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=640859
  GStreamer | gst-plugins-base | git

--- Comment #39 from Håvard Graff (hgr) <havard.graff at tandberg.com> 2011-05-03 15:17:27 UTC ---
I have not yet tried out your patch, but I will soon. Coincidentally (?) we
just got in a bugreport of someone getting +500ms diffs, and hence exceeding
our resync-threshold, so as soon as I get my hands on that data, I will have an
excellent failing bug that your patch might fix :)

> > However, since we deal with jittery networks, the timestamps on the buffers are
> > sometimes very differently inter-spaced, and if we always placed the buffers
> > according to their timestamps, we would have glitches-galore.
> 
> Not necessarily, it depends how bit the jitter is. If it's small, it might not
> be noticeable.
> 

Actually, only one sample of discontinuity can easily be audible. So unless the
jitter is less than 20 microseconds (for 48KHz) it is audible. And the jitter
is almost always bigger than that in VOIP due to RTP/RTCP time-calculations.

> ... but I think renaming to "alignment-threshold" should be on a
> separate bug report, and I'm not sure people would be in favor of braking ABI
> in that way.

Well, it used to be hard-coded, and then it just piggy-backed on another
variable, so I think it getting its own would be welcomed.

Also, is there any reason you have two patches? Should they not be merged?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.