[Bug 649878] New: [multiqueue] regression: gst_single_queue_new not MT-safe

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=649878
  GStreamer | gstreamer (core) | git

           Summary: [multiqueue] regression: gst_single_queue_new not
                    MT-safe
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: blocker
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: mnauw at users.sourceforge.net
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=187566)
 View: https://bugzilla.gnome.org/attachment.cgi?id=187566
 Review: https://bugzilla.gnome.org/review?bug=649878&attachment=187566

multiqueue: ensure MT-safety when adding a pad

gst_single_queue_new creates a single queue and adds this to the multiqueue,
but it seems that GST_MULTI_QUEUE_MUTEX_UNLOCK is performed too soon. 
Specifically, the lock is dropped before various fields of the single queue are
setup, most notably the actual ->queue DataQueue, although the single queue is
then already added to the list of multiqueue's queues.  Particularly the latter
field may get accessed in some underrun/overrun callback iterating over all
GstSingleQueue (leading to a NULL data queue).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.